Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eks): add correct helm asset snapshot #30835

Closed
wants to merge 1 commit into from

Conversation

shikha372
Copy link
Contributor

@shikha372 shikha372 commented Jul 12, 2024

Issue # (if applicable)

Closes #

Reason for this change

PR##29454 introduced incorrect snapshot changes for the helm asset.

Description of changes

Modified helm asset integration test file to add below flag as part of existing chart installation('rds-chart-release')

atomic: true

Description of how you validated changes

Successful deployment for integration test integ.eks-helm-asset.ts

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team July 12, 2024 05:22
@github-actions github-actions bot added the p2 label Jul 12, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 12, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ae9f682
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@shikha372 shikha372 marked this pull request as ready for review July 12, 2024 16:47
@@ -118,15 +118,15 @@
}
}
},
"87e05e7e56d00f8bd9133b97480ff01b622c9f7f500f8544cef311a412454395": {
"0ab01c1684677dce72948d48cdd47d31aef3137c741b066737be81fe5944e6fe": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This asset hash update means that there should also be changes to the asset files. At the very least, they should be renamed.

@shikha372
Copy link
Contributor Author

closing this one as snapshots are updated in this PR

@shikha372 shikha372 closed this Jul 23, 2024
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants