Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make file Deletes everything #14

Closed
ashutoshvct opened this issue Apr 1, 2016 · 7 comments
Closed

Make file Deletes everything #14

ashutoshvct opened this issue Apr 1, 2016 · 7 comments

Comments

@ashutoshvct
Copy link

In my Macos i downloaded the SDK and i clicked the make file and it started removing apps from my pc.
You should have a warning stating that do not open the make file.

@johnrotach
Copy link

Hello @ashutoshvct,

We are looking into this issue and trying to reproduce. Can you provide more detail on what you did prior to observing this? Did you clone from GitHub or download the Linux/Mac OS port tarball from S3? In which directory was the makefile located when you double clicked on it? Specifically which applications (and locations) were removed?

In the meantime we will continue to try and reproduce on our end.

John

@ashutoshvct
Copy link
Author

Hi,
I had downloaded a tarball. My downloads folder was affected and application folder.
I had created it in users/…/aws_iot/my_app

On Apr 1, 2016, at 9:55 PM, John Rotach notifications@github.com wrote:

Hello @ashutoshvct https://github.com/ashutoshvct,

We are looking into this issue and trying to reproduce. Can you provide more detail on what you did prior to observing this? Did you clone from GitHub or download the Linux/Mac OS port tarball from S3? In which directory was the makefile located when you double clicked on it? Specifically which applications (and locations) were removed?

In the meantime we will continue to try and reproduce on our end.

John


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub #14 (comment)

@johnrotach
Copy link

Thanks for getting back to us. A couple more questions:

Specifically what makefile did you double-click? When you do this in OS X, what application is invoked to run the makefile?

@ashutoshvct
Copy link
Author

in samples i clicked the make file and it opened a terminal and started removing my apps.

On Apr 1, 2016, at 10:31 PM, John Rotach notifications@github.com wrote:

Thanks for getting back to us. A couple more questions:

Specifically what makefile did you double-click? When you do this in OS X, what application is invoked to run the makefile?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub #14 (comment)

@johnrotach
Copy link

Hello @ashutoshvct,

We have now verified what we believe to be the issue. The file permissions on the makefile had the executable flag set. This allowed you to execute the makefile directly and OS X interpreted it as a shell script. If this flag was set appropriately OS X would not have allowed you to execute the file by double-clicking it.

It is important to call out the correct way to use a makefile is not to execute the makefile itself, but rather to run the make utility taking the Makefile as an input file. This is done by simply running make from within the respective samples directory:

cd sample_apps/subscribe_publish_sample/
make

We are in the process of pushing out a release that removes the executable flag from all of the files in this repository. This will prevent accidental execution of any of the files in the future. We apologize for any inconvenience this has caused you and appreciate you bringing this to our attention.

John

@bhadrip
Copy link
Contributor

bhadrip commented Apr 2, 2016

v1.1.1 fixes this issue.

@bhadrip bhadrip closed this as completed Apr 2, 2016
@ashutoshvct
Copy link
Author

Hi,
Thanks for the support!!!

On Apr 2, 2016, at 7:28 AM, bhadrip notifications@github.com wrote:

v1.1.1 https://github.com/aws/aws-iot-device-sdk-embedded-C/releases/tag/v1.1.1 fixes this issue.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub #14 (comment)

aggarw13 added a commit to aggarw13/aws-iot-device-sdk-embedded-C that referenced this issue Nov 29, 2019
Remove "clientID" from RegisterThing payload response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants