Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OTA_Shutdown API calls #1538

Merged
merged 4 commits into from
Feb 11, 2021
Merged

Update OTA_Shutdown API calls #1538

merged 4 commits into from
Feb 11, 2021

Conversation

pvyawaha
Copy link
Contributor

@pvyawaha pvyawaha commented Feb 10, 2021

Issue #, if available:

Description of changes:
This change updates the OTA_Shutdown calls by adding a new parameter for unsubscribe flag.
The change is in both OTA demos - MQTT and HTTP

Dependency for this change is aws/ota-for-aws-iot-embedded-sdk#154

OTA Submodule is updated in this PR which has above dependency.

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Copy link
Contributor

@yanjos-dev yanjos-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the change in the OTA repo that this depends on is merged, can you move the submodule pointer to point to it in this PR? That way we don't break the demo in between PRs. I'll approve this after that.

@pvyawaha pvyawaha merged commit 71679f2 into aws:main Feb 11, 2021
@pvyawaha pvyawaha deleted the otademo/update_shutdown branch February 11, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants