Update corePKCS11 demo to read the public key #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbartell
previously approved these changes
Jul 16, 2021
aggarw13
reviewed
Jul 16, 2021
| @@ -155,7 +155,7 @@ CK_RV PKCS11SignVerifyDemo( void ) | |||
| { | |||
| result = xFindObjectWithLabelAndClass( session, | |||
| pkcs11demoPRIVATE_KEY_LABEL, | |||
| sizeof( pkcs11demoPRIVATE_KEY_LABEL ), | |||
| sizeof( pkcs11demoPRIVATE_KEY_LABEL ) - 1, | |||
There was a problem hiding this comment.
Is this change to discount the NUL character?
The comment in the pkcs11_demo_objects.c file mentions that the labels should not be NUL terminated...
There was a problem hiding this comment.
Yes, it is not NUL terminated in the objects demo as well because when passed to publicKeyTemplate/privateKeyTemplate, the NUL character is removed through the length.
Hence, NUL character must also be subtracted from the length in the sign and verify demo.
There was a problem hiding this comment.
Okay, should the It should not be NULL terminated. comment be removed then as it is not fitting in declaration of the byte arrays..
|
A note about this fix in the CHANGELOG would be valuable |
yourslab
changed the title
aggarw13
approved these changes
Jul 16, 2021
xortothemoon
approved these changes
Jul 17, 2021
paulbartell
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the demo so that it doesn't treat the public key as a private key
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.