[P2 Release] HTTP_S3_download demo updates using SigV4 Library #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 875cab1.
yourslab
previously approved these changes
Aug 12, 2021
| .hashFinal = sha256Final, | ||
| .pHashContext = &hashContext, | ||
| .hashBlockLen = SIGV4_HASH_MAX_BLOCK_LENGTH, | ||
| .hashDigestLen = SIGV4_HASH_MAX_DIGEST_LENGTH, |
There was a problem hiding this comment.
Yes, it works with this macro. However, that won't work when multiple hash algorithms are used at the same time. Pls create a macro in the demo that specifies the block and digest length for SHA256.
yourslab
previously approved these changes
Aug 12, 2021
…ang/aws-iot-device-sdk-embedded-C into HTTP-s3-download-demo-Final
This reverts commit c6d25e6.
aggarw13
previously approved these changes
Aug 13, 2021
aggarw13
previously approved these changes
Aug 14, 2021
yourslab
previously approved these changes
Aug 14, 2021
…ang/aws-iot-device-sdk-embedded-C into HTTP-s3-download-demo-Final
yourslab
approved these changes
Aug 14, 2021
abhidixi11
approved these changes
Aug 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes related to use of SigV4 library in HTTP_S3_download demo for generation of Authorization header.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.