Fix to issue #35 #177
Merged
Fix to issue #35 #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made code more robust to read timeout. SSL_READ_TIME_OUT will not create a disconnect anymore. Yield should now yield the correct amount of time. Data aggregation will ensure data stays in sync Fix a potential overflow in the code: _aws_iot_mqtt_internal_read_packet was not checking buffer size properly Fix a bug in _aws_iot_mqtt_internal_decode_packet_remaining_len, len was not correctly increase
gordonwang0
pushed a commit
that referenced
this pull request
May 4, 2018
* Memory corruption fix + timeout robustness feature Made code more robust to read timeout. SSL_READ_TIME_OUT will not create a disconnect anymore. Yield should now yield the correct amount of time. Data aggregation will ensure data stays in sync Fix a potential overflow in the code: _aws_iot_mqtt_internal_read_packet was not checking buffer size properly Fix a bug in _aws_iot_mqtt_internal_decode_packet_remaining_len, len was not correctly increase
This was referenced Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #35
Made code more robust to read timeout.
SSL_READ_TIME_OUT will not create a disconnect anymore.
Yield should now yield the correct amount of time.
Data aggregation will ensure data stays in sync
Memory corruption fix + timeout robustness feature
Fix a potential overflow in the code: _aws_iot_mqtt_internal_read_packet was not checking buffer size properly
Fix a bug in _aws_iot_mqtt_internal_decode_packet_remaining_len, len was not correctly increase