Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Deleted field to support codecommit ref delete events #531

Merged
merged 6 commits into from
Nov 30, 2023

Conversation

praveenk007
Copy link
Contributor

Issue #, if available:
#528

Description of changes:
Added Deleted field so that the consumer is able to identify reference delete events.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2ff7818) 72.63% compared to head (0a79053) 72.63%.

❗ Current head 0a79053 differs from pull request most recent head 06e65fe. Consider uploading reports for the commit 06e65fe to get more accurate results

Files Patch % Lines
events/code_commit.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #531   +/-   ##
=======================================
  Coverage   72.63%   72.63%           
=======================================
  Files          26       26           
  Lines        1407     1407           
=======================================
  Hits         1022     1022           
  Misses        314      314           
  Partials       71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leepa
Copy link

leepa commented Nov 8, 2023

You've committed your .idea folder. You'll want to remove that.

@bmoffatt
Copy link
Collaborator

Wasn't able to find quickly a docs reference, so had to run a quick test by hand to verify

{'Records': [{'awsRegion': 'us-west-2', 'codecommit': {'references': [{'commit': '023f0e4effa8955bd8dbae4f104b74206cf74252', 'deleted': True, 'ref': 'refs/heads/yoho'}]}, ...

LGTM! Thanks!

@bmoffatt bmoffatt merged commit 0ad0619 into aws:main Nov 30, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants