Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVP_PKEY_CTX_ctrl_str support for RSA key types #1847

Closed
wants to merge 4 commits into from

Conversation

justsmth
Copy link
Contributor

Depends On

Description of changes:

  • Implement EVP_PKEY_CTX_ctrl_str for the RSA key types.

Testing:

Added new test suite: evp_ctx_test.cc

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth changed the title Evp pkey ctx ctrl str rsa EVP_PKEY_CTX_ctrl_str support for RSA key types Sep 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 95.62044% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.57%. Comparing base (51d9a8d) to head (72144b5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crypto/fipsmodule/evp/p_rsa.c 94.54% 3 Missing ⚠️
crypto/fipsmodule/evp/evp_ctx_test.cc 94.59% 1 Missing and 1 partial ⚠️
crypto/mem.c 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1847      +/-   ##
==========================================
+ Coverage   78.49%   78.57%   +0.07%     
==========================================
  Files         583      584       +1     
  Lines       98516    98672     +156     
  Branches    14129    14163      +34     
==========================================
+ Hits        77332    77527     +195     
+ Misses      20557    20518      -39     
  Partials      627      627              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth closed this Sep 12, 2024
@justsmth justsmth deleted the EVP_PKEY_CTX_ctrl_str-RSA branch September 12, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants