Network Policy - Strict mode support #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achevuru
commented
Feb 14, 2024
pkg/rpc/rpc_handler.go
Outdated
| } | ||
|
|
||
| // RunRPCHandler handles request from gRPC | ||
| // func RunRPCHandler(ebpfClient ebpf.BpfClient) error { |
There was a problem hiding this comment.
Need to remove the stale line
achevuru
commented
Feb 14, 2024
jayanthvn
reviewed
Feb 14, 2024
jayanthvn
reviewed
Feb 15, 2024
| func (l *bpfClient) IsMapUpdateRequired(podIdentifier string) bool { | ||
| mapUpdateRequired := false | ||
| if _, ok := l.policyEndpointeBPFContext.Load(podIdentifier); !ok { | ||
| l.logger.Info("No map instance found") |
There was a problem hiding this comment.
nit: Do we need this log line since the caller has log already?
jayanthvn
previously approved these changes
Feb 15, 2024
This was referenced Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
NA
Description of changes:
VPC CNI recently introduced support for Kubernetes Network policies using eBPF data plane. Current implementation of Network policy feature does not gate pod launch until policies are reconciled against it and so there can be a time window between when the Pod moves to Ready state and when the network policies are reconciled and configured against the pod during which no policies are enforced against either ingress or egress traffic from the pod. Network Policy controller will start the reconciliation process for a new pod after an IP address is assigned to the Pod.
We plan to introduce a new mode,
Strictmode, that will gate pod launch until active network policies are enforced against a newly launched pod. We attempt to program relevant firewall entries for this pod, if the local node agent is aware of the policies configured against it. For example, if this is a new replica of an existing pod/deployment then the localnode agent will have the policy information available to it in it's cache. If not, we will leave the pod in default deny state
until the Network Policy controller reconciles existing policies against this pod.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.