Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the region flag to the imagebuilder component custom script download action #6425

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

dreambeyondorange
Copy link
Contributor

Tests

  • Ran integ tests locally for createami custom component

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dreambeyondorange dreambeyondorange added the skip-changelog-update Disables the check that enforces changelog updates in PRs label Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.21%. Comparing base (c3154c1) to head (3aa2c68).
Report is 19 commits behind head on release-3.10.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-3.10    #6425   +/-   ##
=============================================
  Coverage         90.20%   90.21%           
=============================================
  Files               181      181           
  Lines             15898    15901    +3     
=============================================
+ Hits              14341    14345    +4     
+ Misses             1557     1556    -1     
Flag Coverage Δ
unittests 90.21% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dreambeyondorange dreambeyondorange merged commit a38fcf0 into aws:release-3.10 Sep 9, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants