fix(type-safe-api): fix openapi code generation with jdk 17 #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code generation would fail for JDK >11 due to the following issue: OpenAPITools/openapi-generator#13684 Setting JAVA_OPTS works around this issue, allowing for generation with newer JDKs
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 73b8231. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
agdimech
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code generation would fail for JDK >11 due to the following issue:
OpenAPITools/openapi-generator#13684
Setting JAVA_OPTS works around this issue, allowing for generation with newer JDKs.
Tested with both Corretto 17 and Corretto 11.