Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pdk-monorepo): pin syncpack dependency to stay compatible to NodeJS v18 #824

Open
wants to merge 7 commits into
base: mainline
Choose a base branch
from

Conversation

bweigel
Copy link

@bweigel bweigel commented Sep 9, 2024

fixes #823

@JamieMason
Copy link

👋 syncpack v13 should also work for you on Node 18, I reverted the dependency bump which required v20 https://github.com/JamieMason/syncpack/releases/tag/13.0.0

@bweigel bweigel marked this pull request as ready for review September 9, 2024 20:54
Copy link

nx-cloud bot commented Sep 11, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2d27382. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@cogwirrel
Copy link
Member

Thanks for this! Looks like you might need to update more snapshots - can be a bit fiddly with monorepo changes as PDK dogfoods itself :)

@bweigel
Copy link
Author

bweigel commented Sep 18, 2024

Thanks for this! Looks like you might need to update more snapshots - can be a bit fiddly with monorepo changes as PDK dogfoods itself :)

@cogwirrel, I don't know why it still fails. I can run the pnpm build locally, without any issues... Well except the rsync is missing from the devcontainer image, but that I can install and after that it just works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] @aws/pdk (monorepo) is incompatible with NodeJs <20 due to transient syncpack..minimatch dependency
3 participants