Merge pull request #2026 from aws/firstissue

fix #1998 int overflow bug in 32 bit architecture
aws · Feb 20, 2023 · 8e6fa27 · 8e6fa27
2 parents 9af2842 + 1ca1e18
commit 8e6fa27
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 6 deletions.
diff --git a/.changelog/f4bce07753bc4db9a6e8bf18d0b8ce8b.json b/.changelog/f4bce07753bc4db9a6e8bf18d0b8ce8b.json
@@ -0,0 +1,9 @@
+{
+    "id": "f4bce077-53bc-4db9-a6e8-bf18d0b8ce8b",
+    "type": "bugfix",
+    "description": "fix int overflow bug on 32 bit architecture",
+    "modules": [
+        ".",
+        "service/internal/benchmark"
+    ]
+}
diff --git a/aws/retry/jitter_backoff_test.go b/aws/retry/jitter_backoff_test.go
@@ -38,7 +38,7 @@ func TestExponentialJitterBackoff_AttemptDelay(t *testing.T) {
 		"max delay": {
 			MaxBackoff: 20 * time.Second,
 			RandFloat:  func() (float64, error) { return maxB, nil },
-			Attempt:    1 << 53,
+			Attempt:    2147483647,
 			Expect:     timeconv.FloatSecondsDur(maxB * math.Exp2(math.Log2(20))),
 		},
 	}

diff --git a/service/internal/benchmark/dynamodb/customizations_test.go b/service/internal/benchmark/dynamodb/customizations_test.go
@@ -25,8 +25,8 @@ import (
 
 type testData struct {
 	filename         string
-	respChecksum     int
-	respGzipChecksum int
+	respChecksum     int64
+	respGzipChecksum int64
 }
 
 func BenchmarkCustomizations(b *testing.B) {
@@ -71,7 +71,7 @@ func benchCustomizationsOld(b *testing.B, c testData) {
 			r.HTTPResponse = &http.Response{
 				StatusCode: 200,
 				Header: http.Header{
-					"X-Amz-Crc32": []string{strconv.Itoa(c.respChecksum)},
+					"X-Amz-Crc32": []string{strconv.FormatInt(c.respChecksum, 10)},
 				},
 				ContentLength: int64(len(body)),
 				Body:          ioutil.NopCloser(bytes.NewReader(body)),
@@ -127,7 +127,7 @@ func benchCustomizationsSmithy(b *testing.B, c testData) {
 		Region:      "us-west-2",
 		Credentials: unit.StubCredentialsProvider{},
 		HTTPClient: &mockClient{
-			ChecksumHeaderValue: []string{strconv.Itoa(c.respChecksum)},
+			ChecksumHeaderValue: []string{strconv.FormatInt(c.respChecksum, 10)},
 			ScanRespBody:        body,
 		},
 	}
@@ -141,7 +141,7 @@ func benchCustomizationsSmithy(b *testing.B, c testData) {
 	b.Run("all enabled", func(b *testing.B) {
 		client := dynamodb.New(options, func(o *dynamodb.Options) {
 			o.HTTPClient = &mockClient{
-				ChecksumHeaderValue: []string{strconv.Itoa(c.respGzipChecksum)},
+				ChecksumHeaderValue: []string{strconv.FormatInt(c.respGzipChecksum, 10)},
 				ScanRespGzipBody:    gzipBody,
 			}
 			o.DisableValidateResponseChecksum = false