Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-sdk/types@^3.1.0 dependency generates error TS2305 with aws-sdk/* since 3.54.1 #337

Closed
KeithGillette opened this issue Apr 16, 2022 · 1 comment · Fixed by #373
Closed

Comments

@KeithGillette
Copy link

Per @aws-sdk issue #3437, I believe a PR incorporated into @aws-sdk/*@3.54.1, which moved several types from @aws-sdk/shared-ini-file-loader into @aws-sdk/types, generated an incompatibility with aws-crypto packages depending on aws-sdk/types@^3.1.0, resulting in error TS2305 when running tsc on a project with the default tsconfig.json skipLibCheck: false.

In testing with a project dependent upon @aws-crypto/sha256-browser@2.0.1, forcing installation of @aws-sdk/types@latest prevents the TS2305 error. Can @aws-crypto packages be updated to a newer @aws-sdk/types compatible with the latest @aws-sdk releases?

texastony added a commit to texastony/aws-sdk-js-crypto-helpers that referenced this issue Jun 21, 2022
@texastony texastony reopened this Jun 21, 2022
@josecorella
Copy link
Contributor

Hello @KeithGillette!

Thank you for bringing this to our attention; we have put out a fix and released it. You should be able to pick it up in the latest version of the @aws-crypto packages.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants