Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add filterSensitiveLog method to Structure namespaces #1130

Merged
merged 18 commits into from
May 27, 2020
Merged

feat: add filterSensitiveLog method to Structure namespaces #1130

merged 18 commits into from
May 27, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented May 1, 2020

Issue #, if available:
Refs: smithy-lang/smithy-typescript#170

Description of changes:
codegen to add filterSensitiveLog method for Structure namespaces

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr mentioned this pull request May 1, 2020
Merged
@trivikr trivikr marked this pull request as draft May 1, 2020 05:47
@codecov-io

This comment has been minimized.

Sign in to view
@aws-sdk-js-automation

This comment has been minimized.

Sign in to view
@aws-sdk-js-automation

This comment has been minimized.

Sign in to view
@aws-sdk-js-automation

This comment has been minimized.

Sign in to view
@aws-sdk-js-automation

This comment has been minimized.

Sign in to view
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request head (sensitive-trait@ce4bb51). Click here to learn what that means.
The diff coverage is n/a.

@aws-sdk-js-automation

This comment has been minimized.

Sign in to view
@aws-sdk-js-automation

This comment has been minimized.

Sign in to view
@trivikr trivikr marked this pull request as ready for review May 27, 2020 22:03
trivikr added 17 commits May 27, 2020 22:04
@trivikr
chore: add SENSITIVE_STRING constant in smithy-client
e837a27
@trivikr
chore: codegen for filterSensitiveLog for lists and structures
50b5d99
@trivikr
fix: filterSensitiveLog in arrays of arrays
34b520c
@trivikr
chore: codegen for Array<Array<SimpleShape>> fix
2e242cf
@trivikr
chore: codegen for MapShape inside Structure
a703f16
@trivikr
chore: codegen for moving reducer method outside memberShape comparison
ff3a46c
@trivikr
chore: codegen to remove redundant filterSensitiveLog methods
5b80e13
@trivikr
chore: codegen to remove unnecessary code
466aa8d
@trivikr
chore: codegen filterSensitiveLog for Map inside Collection
96fa3ad
@trivikr
chore: codegen for returning any from filterSensitiveLog
1ba8149
@trivikr
chore: codegen filterSensitiveLog for Collection inside Map
47c37ea
@trivikr
chore: codegen filterSensitiveLog for Map inside Map
3b22f00
@trivikr
chore: codegen for bugfix in filterSensitiveLog for Map of Map
3b14c86
@trivikr
chore: update protocol_tests
dd0f9b9
@trivikr
chore: use array Shorthand symtax (rebased from master)
7f58eb8
@trivikr
feat: use desctructuring in array.reduce
0fde106
@trivikr
Add writeStructureFilterSensitiveLog
a05c5a2
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: ce4bb51
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

alexforsyth
alexforsyth approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@trivikr trivikr merged commit 8eff087 into aws:master May 27, 2020
@trivikr trivikr deleted the sensitive-trait branch May 27, 2020 22:26
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexforsyth alexforsyth alexforsyth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@trivikr @codecov-io @aws-sdk-js-automation @codecov-commenter @alexforsyth