chore(middleware-host-header): move to low priority #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS Signer requires a request to contain a `host` header, mostly the same as the request's `hostname`. For the customizations that modifies the request's `hostname`, they need to be applied before this middleware, Otherwise the `hostname` and `host` header would mismatch. It mean these middleware **must** be applied relatively before this middleware. By moving it low priority, it reduce the possibility of mistakenly adding customizations applied after this middleware. Developers only need to apply the customizations to the `build` step, and they will be applied before this middleware by default.
trivikr
approved these changes
Sep 25, 2020
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
AWS Signer requires a request to contain a
hostheader, mostly the same as the request'shostname.For the customizations that modifies the request's
hostname, they need to be applied before thismiddleware, Otherwise the
hostnameandhostheader would mismatch. It mean these middlewaremust be applied relatively before this middleware. By moving it low priority, it reduce the possibility
of mistakenly adding customizations applied after this middleware. Developers only need to apply the
customizations to the
buildstep, and they will be applied before this middleware by default.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.