feat(util-dynamodb): add option to convert class instance to map #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reason: binary is of type object and the check needs to be done before typeof object
This will marshall objects with typeof === "object" using convertToMapAttr
Codecov Report
@@ Coverage Diff @@
## master #1969 +/- ##
==========================================
+ Coverage 79.30% 79.83% +0.52%
==========================================
Files 368 368
Lines 15132 15553 +421
Branches 3222 3369 +147
==========================================
+ Hits 12001 12417 +416
- Misses 3131 3136 +5
Continue to review full report at Codecov.
|
trivikr
changed the title
Reason: we already convert null, binary, array, sets, pure JavaScript objects which also belong to Object.Prototype inheritance chain. This configuration converts other objects, aka different constructor.
trivikr
force-pushed
the
util-dynamodb-marshallObjects
branch
from
efb97fa
to
87d236c
Compare
trivikr
changed the title
AllanZhengYP
approved these changes
Jan 28, 2021
Reason: converting undefined, null and binary attributes is already moved outside the function to support convertClassInstanceToMap configuration
AllanZhengYP
approved these changes
Jan 28, 2021
Number(1) creates JavaScript primitive value, while new Number(1) creates the Number class instance
AllanZhengYP
approved these changes
Jan 28, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This was referenced Feb 8, 2021
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Refs: #1647
Closes: #1535
Closes: #1865
Closes: #1534
Closes: #1861
Closes: #1102
Closes: #1534
Description
adds option to convert class instance to map in
@aws-sdk/util-dynamodbTesting
Unit tests for marshall and convertToAttr functions
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.