Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: attempt to CodeGen DynamoDB DocumentClient #2083

Closed
wants to merge 8 commits into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Feb 24, 2021

Issue

Attempt to use generate code for DocumentClient to fix #1223

Description

This was an attempt to generate code for DocumentClient, which was abandoned because of following reasons:

  • The DynamoDB DocumentClient customization is specific to DynamoDB, and it's rarely updated. In JS SDK v2, the original DocumentClient was written in 2015 and the only major update it received was to add transact commands in 2018
  • The customization output is fairly complex for some commands like batchGet/batchWrite. Writing a Java CodeGen for this customization would be even more complex. An example can viewed in file AddDocumentClientCommandsPlugin.java in this PR. The Java CodeGen cannot directly reuse existing client and command generators, and will have to write new ones.
  • The manually written DocumentClient (written for PoC and design) already covers five commands - i.e. get, put, delete, batchGet, batchWrite. Only five more commands will need to be written.

Additional context

Will be super-ceded by #2062


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr changed the title chore: add basic AddDocumentClientCommandsPlugin feat: attempt to CodeGen DynamoDB DocumentClient Feb 24, 2021
@trivikr trivikr closed this Feb 24, 2021
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 9e9a1ac
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2021
@trivikr trivikr deleted the codegen-documentclient branch March 15, 2021 04:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DynamoDB documentClient support
2 participants