fix(signature-v4-multi-region): make conditional require call in node.js only #5203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
fix/crt
branch
2 times, most recently
from
f04a3ad
to
a3b1fa9
Compare
siddsriv
approved these changes
Sep 12, 2023
AllanZhengYP
approved these changes
Sep 12, 2023
trivikr
reviewed
Sep 13, 2023
trivikr
approved these changes
Sep 13, 2023
kuhe
changed the title
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #5135
mentioned in #4797
fixes #4464
related to #2822
partially addresses #4126
fixes #4373
signature-v4-crtandsignature-v4-multi-region.crtnow depends onmulti-region, andmulti-regiondoes not depend oncrt, even optionally.signature-v4-crt, it will inject itself into a container that is used bysignature-v4-multi-region.revision 1: