fix(util-dynamodb): fix signature overload resolution for marshall() fn #6195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
approved these changes
Jun 13, 2024
kuhe
commented
Jun 13, 2024
| data: Map<string, NativeAttributeValue> | Record<string, NativeAttributeValue>, | ||
| options?: marshallOptions | ||
| ): Record<string, AttributeValue>; | ||
| export function marshall(data: any, options?: marshallOptions): any; |
There was a problem hiding this comment.
added this any => any signature to prevent inputs typed as any from matching to some other signature.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
fixes #4828
this re-attempts #4829 (reverted)
reported issue causing the revert #4901. I don't think this was valid in retrospect, we reverted hastily.
Description
Fix overload signature resolution for
marshall(), with tests this time.Testing
type-checked unit tests