fix(codegen): use AWS SDK default credentials as sigv4 default credentials #6431
Conversation
| } else { | ||
| // isSigV4Service and !isAwsService are implied here. | ||
| return MapUtils.of( | ||
| "credentials", writer -> { |
There was a problem hiding this comment.
I'm not up to speed, but what's the difference between configuring credentials here v/s credentialDefaultProvider? It seems more consistent to configure credentialDefaultProvider here. And that's what it was before.
There was a problem hiding this comment.
credentialDefaultProvider was deprecated by ID&Auth SRA. It is a field that is only generated when the AwsSdkCustomizeSigV4Auth plugin is activated by the isAwsService and isSigV4Service conditionals in conjunction, and relies on data from the (AWS) service trait.
That plugin contains the config resolver that processes the credentialDefaultProvider field along with a few other AWS customizations. Rather than bringing all of that in, I'm using a default value for the credentials field, which is functionally very similar.
There was a problem hiding this comment.
credentialDefaultProvider seems to be a quirk from legacy dev. Even in legacyAuth, it was simply assigned onto the credentials field if the credentials field was empty during config resolution.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
internal
Description
For the scenario of a non-AWS service with the sigv4 trait, this PR modifies the ID&Auth SRA codegen behavior to provide the AWS SDK default credential chain as the default credentials object, for consistency with the legacyAuth behavior.
This was not present in the SRA implementation, presumably because of the desired separation between AWS and white label clients.
This only applies to codegen that uses both smithy-typescript and smithy-typescript-aws. If you only use smithy-typescript, it isn't currently aware of sigv4 at all. Sigv4 handling may need to be moved into smithy-typescript, but is out of scope of this PR.
Testing
new integ test