fix(middleware-flexible-checksums): use union for new config types #6489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
force-pushed
the
type-flexchecks
branch
from
9684dbd
to
a66eda9
Compare
kuhe
reviewed
Sep 17, 2024
| if (!(key in obj)) return undefined; | ||
|
|
||
| const value = obj[key]!.toUpperCase(); | ||
| if (!Object.values(union).includes(value)) { | ||
| throw new TypeError(`Cannot load ${type} '${key}'. Expected one of ${Object.values(union)}, got '${obj[key]}'.`); | ||
| } | ||
|
|
||
| return value; | ||
| return value as U[K]; |
There was a problem hiding this comment.
note to self: the type U[K] is guaranteed by the thrown error. value must be a value of union.
kuhe
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Missed in #6470
Description
Use union for new config types
requestChecksumCalculationandresponseChecksumValidationTesting
CI
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.