-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(middleware-flexible-checksums): use RequestChecksumCalculation and ResponseChecksumValidation #6492
Draft
trivikr
wants to merge
10
commits into
aws:main
Choose a base branch
from
trivikr:middleware-flexcheck-interceptor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ba24558. The ResponseChecksumValidation should be consumed in request middleware.
…equestValidationModeMember]
trivikr
changed the title
chore(middleware-flexible-checksums): add flexibleChecksumsInterceptorMiddleware
chore(middleware-flexible-checksums): use RequestChecksumCalculation and ResponseChecksumValidation
Sep 18, 2024
The PR is ready for review. It's marked as draft, as it shouldn't be merged at this time. |
kuhe
approved these changes
Sep 19, 2024
packages/middleware-flexible-checksums/src/flexibleChecksumsInputMiddleware.ts
Show resolved
Hide resolved
The default checksum is changed from CRC32 to SHA256 based on benchmarks provided in #6499 |
kuhe
approved these changes
Sep 20, 2024
trivikr
force-pushed
the
middleware-flexcheck-interceptor
branch
from
September 20, 2024 19:59
28c1222
to
aad6e6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
flexibleChecksumsInterceptorMiddleware
Description
flexibleChecksumsInterceptorMiddleware
to populateinput[requestValidationModeMember]
Testing
Unit testing in CI
Also, verified that checksums are computed by default
Output
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.