Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getter and setter for external packages relying on AWS.CognitoIdentityCredentials.identityId #1272

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Dec 15, 2016

Resolves #1238

/cc @chrisradek

@coveralls
Copy link

coveralls commented Dec 15, 2016

Coverage Status

Coverage increased (+0.009%) to 88.152% when pulling 8471cf5 on jeskew:fix/ensure-cognito-identityId-always-loaded-from-cache-on-access into d0aa9db on aws:master.

@jeskew jeskew force-pushed the fix/ensure-cognito-identityId-always-loaded-from-cache-on-access branch from 8471cf5 to 2c42bfc Compare December 15, 2016 21:15
@coveralls
Copy link

coveralls commented Dec 15, 2016

Coverage Status

Coverage increased (+0.01%) to 88.154% when pulling 2c42bfc on jeskew:fix/ensure-cognito-identityId-always-loaded-from-cache-on-access into d0aa9db on aws:master.

@johnborges
Copy link

@jeskew would you mind committing your branch? I'de like to test out your fix with my project.

@jeskew
Copy link
Contributor Author

jeskew commented Dec 16, 2016

The branch is public on my fork of this repo. (If you're using webpack, you can install a specific branch from an arbitrary fork per the instructions here).

@johnborges
Copy link

Thanks. I can confirm this fix is working for me.

@chrisradek
Copy link
Contributor

:shipit:

@jeskew jeskew merged commit dd2ec81 into aws:master Jan 3, 2017
@jeskew jeskew deleted the fix/ensure-cognito-identityId-always-loaded-from-cache-on-access branch January 3, 2017 18:50
@lock
Copy link

lock bot commented Sep 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS.config.credentials.get() resets IdentityId to null when offline.
4 participants