Enforce go1.16.6 as minimum version in actions #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified continuous build is using Go1.16.6: https://github.com/aws/aws-xray-daemon/pull/148/checks?check_run_id=3125636014#step:3:10 This means the automated image publishing will use the same version when publishing to ECR/Dockerhub. |
srprash
approved these changes
Jul 21, 2021
|
Just want to confirm was this PR necessary? I thought the previous syntax always uses the latest version so we'd just have to hit the release workflow to pick it up. I don't think the current syntax is better since then it can confuse maintainers into thinking it needs to be updated on every go patch release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently we are comfortable with taking whatever 1.16.x version is resolved to when publishing the daemon images, however we'd like to have at least Go v1.16.6 for its bug & security fixes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.