Add section in readme to note it uses the aws-sdk-go and hence honors… #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the AWS_SDK_LOAD_CONFIG variable
yogiraj07
suggested changes
Feb 20, 2019
|
|
||
| ## Configuration | ||
|
|
||
| The Aws X-Ray Daemon follows default credential resolution for the [aws-sdk-go](https://docs.aws.amazon.com/sdk-for-go/api/index.html). |
There was a problem hiding this comment.
Can we rename Aws to AWS
| @@ -40,6 +40,13 @@ You can also use [Glide](https://github.com/Masterminds/glide) to manage depende | |||
| ``` | |||
| glide install | |||
| ``` | |||
|
|
|||
| ## Configuration | |||
There was a problem hiding this comment.
This should be Credential Configuration, since X-Ray daemon can be configured through cmd or cfg.yaml file.
|
|
||
| The Aws X-Ray Daemon follows default credential resolution for the [aws-sdk-go](https://docs.aws.amazon.com/sdk-for-go/api/index.html). | ||
|
|
||
| Follow the guidelines [here](https://docs.aws.amazon.com/sdk-for-go/v1/developer-guide/configuring-sdk.html) to configure an IAM role for the AWS X-Ray Daemon to run under. |
There was a problem hiding this comment.
Can rephrase to "Follow the configuration guidelines here".
and remove "to configure an IAM role for the AWS X-Ray Daemon to run under.", since the link is generic and not just specific to IAM roles.
|
Hi @defond0 , Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the AWS_SDK_LOAD_CONFIG variable
Description of changes:
This is just adding mention to the readme about how to configure IAM roles for the daemon. This should be pretty straight forward to anyone looking at the repo and who has worked with the aws_sdk_go. This is mostly because other closed source documentation sources like this make mention of default credential resolutions, without making it clear that it is the go sdk default, not the broader default .
This method addresses the concerns in #19
without changing the behavior of the daemon itself.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.