Export patchPromise function to allow capturing third-party promises (e.g. Bluebird) #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omiseImpl() to allow capturing promises from third party promise libraries (e.g. Bluebird)
|
I'm fine with exposing the actual patching code. But since we already have |
|
@haotianw465 Renamed to patchThirdPartyPromise per your suggestion |
|
@haotianw465 any updates on this? |
haotianw465
approved these changes
Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes patchPromise() as a property of of capturePromise(),
patchPromiseImpl()This allows me to use this method to capture promises from third party promise libraries (e.g. Bluebird) without having to duplicate this logic into our codebase. We need this exposed because we use Bluebird promises throughout our system, including the promises returned by the AWS SDK by way of calling aws.config.setPromisesDependency().
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.