Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to generate support bundle in Airgap environment #8683

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

2ez4szliu
Copy link
Member

*Issue #, if available: 5783

*Description of changes:
Currently eks-anywhere cannot generate support bundle in Airgap environment because eks-a needs to read bundle manifest from remote URL.

This PR fixed the issue by allowing user to specify path of local bundle manifest file so that eks-a does not need to read it from remote URL.

*Testing (if applicable):
Run eksctl to generate support bundle with bundle-manifest flag specified in the command, bundle can be generated successfully.
eksctl-anywhere generate support-bundle -f eks-a-cluster.yaml --bundle-manifest eks-anywhere-downloads/bundle-release.yaml

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added do-not-merge/work-in-progress size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 73.52%. Comparing base (a083f41) to head (514322d).
Report is 59 commits behind head on main.

Files with missing lines Patch % Lines
cmd/eksctl-anywhere/cmd/supportbundle.go 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8683      +/-   ##
==========================================
- Coverage   73.53%   73.52%   -0.01%     
==========================================
  Files         578      578              
  Lines       36557    36561       +4     
==========================================
+ Hits        26882    26883       +1     
- Misses       7955     7958       +3     
  Partials     1720     1720              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Currently eks-anywhere cannot generate support bundle in Airgap environment
because eks-a needs to read bundle manifest from remote URL.

This PR fixed the issue by allowing user to specify path of local
bundle manifest file so that eks-a does not need to read it from
remote URL.
@2ez4szliu 2ez4szliu changed the title [WIP] Fix issue when generating support bundle in Airgap environment Allow user to generate support bundle in Airgap environment Aug 30, 2024
@2ez4szliu 2ez4szliu linked an issue Sep 5, 2024 that may be closed by this pull request
@jacobweinstock
Copy link
Member

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobweinstock

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@2ez4szliu 2ez4szliu merged commit 3a283cd into aws:main Sep 17, 2024
11 of 13 checks passed
@2ez4szliu 2ez4szliu deleted the airgap-bundle branch September 17, 2024 17:54
@2ez4szliu
Copy link
Member Author

/cherry-pick release-0.20

@eks-distro-pr-bot
Copy link
Contributor

@2ez4szliu: new pull request created: #8786

In response to this:

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EKSA Support Bundle for airgap/offline Clusters
4 participants