Update error handling for processing data blocks #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a unit test for when the OTA Agent fails to initialize the file and then the request timer fails to start.
* Add a test for failing to send the events.
* Test for the scenario where the event fails to send.
* Add a test for failing to start the request timer. * Add a test for failing to send the shutdown event after hitting the maximum number of requests.
* Replaced NULL checks for pointers to static variables with asserts. * Added a check for receiving a data block event from the user that has NULL data. * Add a unit test for receiving a null data block.
divekarshubham
approved these changes
Feb 12, 2021
n9wxu
approved these changes
Feb 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error handling in code for ingesting blocks:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.