Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom job and no active job logic and logs #178

Merged
merged 16 commits into from
Feb 24, 2021
Merged

Fix custom job and no active job logic and logs #178

merged 16 commits into from
Feb 24, 2021

Conversation

pvyawaha
Copy link
Contributor

Issue #, if available:

Description of changes: This change -

  • Fixes the logic and error codes to handle custom job
  • Identifies no active job and removes unnecessary file close
  • Removes redundant handling of no active job/parse error
  • Cleanup log in cases of custom job parsing failure and no active jobs

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

divekarshubham
divekarshubham previously approved these changes Feb 22, 2021
View reviewed changes
divekarshubham
divekarshubham previously approved these changes Feb 22, 2021
View reviewed changes
divekarshubham
divekarshubham previously approved these changes Feb 22, 2021
View reviewed changes
gkwicker
gkwicker suggested changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@gkwicker gkwicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

source/ota.c Show resolved Hide resolved
source/ota.c Show resolved Hide resolved
source/ota.c Outdated Show resolved Hide resolved
gkwicker
gkwicker suggested changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@gkwicker gkwicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a unit test for the new length check if we can.

@pvyawaha
Copy link
Contributor Author

Let's add a unit test for the new length check if we can.

Added unit tests in the commit 1443c4d

@gkwicker gkwicker merged commit bfc47ed into main Feb 24, 2021
@pvyawaha pvyawaha deleted the improvelogging branch February 24, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment