Un-resolve xml attribute namespaces #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the XML decoder to un-resolve xml namspaces in attributes. The Go decoder resolves them fully by default, but we need the short names to match attributes to members while decoding.
jasdel
added a commit
to jasdel/smithy
that referenced
this pull request
Jan 12, 2021
Adds additional protocol tests for member bound to XML attribute within a struct that also has an XML namespace. Related to aws/smithy-go#255, aws/aws-sdk-go-v2#1034, aws/aws-sdk-go-v2#1013
jasdel
approved these changes
Jan 12, 2021
JordonPhillips
pushed a commit
to smithy-lang/smithy
that referenced
this pull request
Jan 13, 2021
Adds additional protocol tests for member bound to XML attribute within a struct that also has an XML namespace. Related to aws/smithy-go#255, aws/aws-sdk-go-v2#1034, aws/aws-sdk-go-v2#1013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
This the smithy-go half of what's needed to address aws/aws-sdk-go-v2#1013
Description of changes:
This updates the XML decoder to un-resolve xml namspaces in
attributes. The Go decoder resolves them fully by default, but we
need the short names to match attributes to members while
decoding.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.