codegen: Update generated serde to skip unmodeled input/outputs #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the SDK's generated serializers and deserializers to skip unmodeled input and output shapes for operations. This issue caused generated deserializers to attempt to deserialize operation responses that were not modeled, resulting in an error. Whereas the SDK should of ignored the response if one was present for operations without a modeled output. Related to aws/aws-sdk-go-v2#1047
jasdel
added a commit
to jasdel/aws-sdk-go-v2
that referenced
this pull request
Jan 15, 2021
Updates the AwsQuery and JSONPRC protocols to skip serializing inputs with no methods. Related to aws/smithy-go#261
skmcgrail
reviewed
Jan 15, 2021
codegen/smithy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/CodegenUtils.java
Outdated
Show resolved
Hide resolved
skotambkar
approved these changes
Jan 16, 2021
jasdel
added a commit
to aws/aws-sdk-go-v2
that referenced
this pull request
Jan 16, 2021
…output (#1050) Updates the SDK's generate serializers and deserializers for operations without modeled input and output types. This fixes #1047 where the SDK was attempting to deserialize a response from a service for an operation that had no modeled output. The SDK should of ignored the response instead of trying to deserialize it. This update will not attempt to serialize inputs for operations without modeled inputs, and will discard responses from services of operations with unmodeled outputs. Related to aws/smithy-go#261 Fixes #1047
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the SDK's generated serializers and deserializers to skip unmodeled
input and output shapes for operations.
This issue caused generated deserializers to attempt to deserialize
operation responses that were not modeled, resulting in an error.
Whereas the SDK should of ignored the response if one was present for
operations without a modeled output.
Related to aws/aws-sdk-go-v2#1047
Fixes #262
Input
Unmodeled Input shape serializer functions are not generated.
This update changes API protocol operation serializers for HTTP binding protocols to skip serialization of the request document if the operation's input was not modeled.
This change is not applied to HTTP RPC protocol serializations. This is due to the AwsQuery protocol requiring some protocol specific elements to always be serialized regardless if an input is modeled or not.
Output
Unmodeled output shape serializer functions are not generated.
This update changes all API protocol operation deserializers to discard the response body if the operation's output was not modeled.