-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make TSC the default system clock source #249
Comments
I have a soon pending PR for this. I need to test it first. |
* #249 Making tsc the clock source * Applying changes from review.
This issue can be closed. |
Closed in #272 |
This doesn't appear to be working anymore. See comments in #321 |
seeing the same behavior in v1.15.11-eks-065dce |
Has anyone continued to experience this issue on currently-supported AMI's? |
I don't know if its related, but I usually do not have to open NTP/123 on my NACLs/security groups but with the EKS AMI I am seeing a lot of REJECTs in flow logs Per this https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/set-time.html
Is there any way to use this service at 169.254.169.123 instead of having to open up NTP/123 to a public route? |
Looking into this. I think we should remove our As for #272 -- that PR was a no-op. It's setting the current clocksource during the AMI build process, and the default is reset upon reboot. I think we're fine to set |
@ybstaked are you using Xen or Nitro-based instance types? FWICT, |
Interesting; those are Nitro instance types. If you want to give I'll go ahead and update #1328 to use |
What would you like to be added:
Make the default system clock source "tsc" instead of "xen".
Why is this needed:
Docker containers that do frequent system time lookups can be badly affected by the overhead around the xen system clock source.
AWS's own tuning recommendations suggest this switch.
Is there any reason not to switch to tsc as the default for the EKS images?
The text was updated successfully, but these errors were encountered: