Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix incorrect policy permission guidelines for log collector #1941

Conversation

ryoyanoamazon
Copy link
Contributor

@ryoyanoamazon ryoyanoamazon commented Aug 30, 2024

…ut AmazonSSMManagedInstanceCore

Issue #, if available:

Fixes: #1940

  1. "IAM managed role AmazonSSMManagedInstanceCore" is not a role, it is an AWS managed role.
  2. The IAM managed role AmazonSSMManagedInstanceCore does not have S3:PutObject permission to all S3 resources.

Description of changes:

  1. Modify role into policy about AmazonSSMManagedInstanceCore.
  2. Delete the documentation of The IAM managed role AmazonSSMManagedInstanceCore has S3:PutObject permission to all S3 resources and add an instruction to have the S3:PutObject permission to all S3 resources.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Testing Done

See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.

Copy link
Member

@ndbaker1 ndbaker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! have one suggestion for wording

log-collector-script/linux/README.md Outdated Show resolved Hide resolved
@ndbaker1 ndbaker1 changed the title [Documentation correction] AmazonSSMManagedInstanceCore mentioned as a role is an AWS managed policy, and it does not have S3:PutObject permission to all S3 resources. #1940 docs: update suggested log collector policies Aug 30, 2024
@ndbaker1 ndbaker1 added changelog/exclude Exclude this PR from future changelog entries. documentation Documentation issue labels Aug 30, 2024
@ndbaker1 ndbaker1 changed the title docs: update suggested log collector policies docs: fix incorrect policy permission guidelines for log collector Aug 30, 2024
@ndbaker1 ndbaker1 merged commit 3fafb53 into awslabs:main Aug 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/exclude Exclude this PR from future changelog entries. documentation Documentation issue
Projects
None yet
2 participants