Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry if AWS API returns None #274

Merged
merged 3 commits into from
Jun 2, 2019

Conversation

jaksonwkr
Copy link
Contributor

Issue #, if available:

#271

Description of changes:

Retry command aws eks describe-cluster if API returns None.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mogren mogren requested a review from micahhausler May 22, 2019 02:55
Copy link
Member

@micahhausler micahhausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this if the cluster isn't yet active?

If so, rather than breaking, can you add a call just before the describe-cluster

aws eks wait cluster-active \
    --region=${AWS_DEFAULT_REGION} \
    --name=${CLUSTER_NAME}

@jaksonwkr
Copy link
Contributor Author

Hi @micahhausler, thanks for your feedback.
I did a few more tests and checked that is because the cluster isn't active yet. I'll change to wai until the cluster is ready.

Copy link
Member

@micahhausler micahhausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@micahhausler micahhausler merged commit 88ca2ac into awslabs:master Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants