Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove authenticator binary as a dependency #440

Merged
merged 2 commits into from
Mar 27, 2020
Merged

Remove authenticator binary as a dependency #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
612284a
Merge pull request #1 from awslabs/master
abeer91 Mar 26, 2020
b08a040
Removing dependency on Authenticator binary
abeer91 Mar 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions files/kubelet-kubeconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,14 @@ users:
user:
exec:
apiVersion: client.authentication.k8s.io/v1alpha1
command: /usr/bin/aws-iam-authenticator
command: aws
env:
- name: AWS_STS_REGIONAL_ENDPOINTS
value: regional
args:
- "token"
- "-i"
- "CLUSTER_NAME"
- eks
- --region
- "AWS_REGION"
- "AWS_REGION"
- get-token
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will aws eks get-token use regional sts for us-west-2?
if not, consider add an env AWS_STS_REGIONAL_ENDPOINTS=regional and test it. you should find the sts endpoint in the token itself.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it uses the IAD Endpoint. Will set that environment variable in the Kubeconfig to redirect to regional endpoint.

- --cluster-name
- "CLUSTER_NAME"
1 change: 0 additions & 1 deletion scripts/install-worker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@ S3_PATH="s3://$BINARY_BUCKET_NAME/$KUBERNETES_VERSION/$KUBERNETES_BUILD_DATE/bin

BINARIES=(
kubelet
aws-iam-authenticator
)
for binary in ${BINARIES[*]} ; do
if [[ ! -z "$AWS_ACCESS_KEY_ID" ]]; then
Expand Down