Async cancel test #310
Merged
Async cancel test #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
=======================================
Coverage 88.97% 88.97%
=======================================
Files 17 17
Lines 4935 4936 +1
=======================================
+ Hits 4391 4392 +1
Misses 544 544 |
TingDaoK
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create test that cancels a meta-request using an async-input-stream
Also, stupid and trivial, but
ASSERT_X_EQUALS(expected, got)macros are supposed to take the "expected" value as the 1st arg. Fix anywhere the "expected" value was passed as the 2nd arg.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.