Allow disabling upload checksums while using upload review #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some clients (Mountpoint) might want to disable actually sending upload checksums when talking to S3 endpoints that don't support the additional checksums feature. But they still want to use the upload review callback to at least check that the parts sent matched the checksums they expect. This change makes it possible to set a checksum location of AWS_SCL_NONE while still computing checksums for each upload part. The upload review callback will be invoked as normal, but the checksums won't be included in the requests sent to S3. Signed-off-by: James Bornholt <bornholt@amazon.com>
Signed-off-by: James Bornholt <bornholt@amazon.com>
Before we were relying on the chunk stream to reach the end of its inner checksum stream and then immediately destroy the checksum stream, triggering the checksum finalizer. We need to do the same thing in the non-chunk-stream case. Signed-off-by: James Bornholt <bornholt@amazon.com>
waahm7
approved these changes
Apr 1, 2024
TingDaoK
approved these changes
Apr 2, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
==========================================
- Coverage 89.63% 89.52% -0.12%
==========================================
Files 20 20
Lines 5992 6012 +20
==========================================
+ Hits 5371 5382 +11
- Misses 621 630 +9
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clients (Mountpoint) might want to disable actually sending upload
checksums when talking to S3 endpoints that don't support the additional
checksums feature. But they still want to use the upload review callback
to at least check that the parts sent matched the checksums they expect,
to detect corruption while parts were sitting in CRT memory before being sent.
This change makes it possible to set a checksum location of AWS_SCL_NONE
while still computing checksums for each upload part. The upload review
callback will be invoked as normal, including per-part checksums, but the
checksums won't be included in the requests sent to S3.
(My C is pretty rusty these days, so, uh, feedback welcome)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.