Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pipeline and submodule updates for Fix PendingConnectionAcquires #830

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Sep 16, 2024

Issue #, if available:

  • In our pipeline, it failed to use ©, maven javadoc complains about:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.4.0:jar (attach-javadocs) on project aws-crt: MavenReportException: Error while generating Javadoc: Error checking stale data: Input length = 1 
  • I cannot reproduce it locally with the same version of maven and java. :).
  • Have to remove the © from the release profile. So that it's still showed from our doc, but not affect our release pipeline

Description of changes:

  • Remove © from the release profile for java doc.
  • Update submodule picked up fix PendingConnectionAcquires on http

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@TingDaoK TingDaoK marked this pull request as ready for review September 16, 2024 02:34
@TingDaoK TingDaoK enabled auto-merge (squash) September 16, 2024 16:13
@TingDaoK TingDaoK merged commit 7c48ca0 into main Sep 16, 2024
50 checks passed
@TingDaoK TingDaoK deleted the fix-pipeline branch September 16, 2024 16:36
@TingDaoK TingDaoK changed the title fix pipeline fix pipeline and submodule updates for Fix PendingConnectionAcquires Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants