Address issues with latest AWS-LC and OpenBSD #569
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The latest AWS-LC was crashing on OpenBSD 7.4, when running test
test.test_http_client.TestClient.test_connect_pq_tlsv1_0_2021_05
Investigation:
AWS-LC added OpenBSD 7.4 and 7.5 Support in v1.26.0. Ironically, these changes broke our existing OpenBSD 7.4 CI. My understanding is: "support OpenBSD" means "support fancy assembly math, instead of using vanilla C code math" on OpenBSD. This fancy assembly math currently reads from the .text section of the library, which is forbidden if a library is linked with the
--execute-only
flag, which OpenBSD 7.4+ uses by default.Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.