Update and fix CI workflows #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 42f55c5.
marcomagdy
reviewed
Nov 24, 2021
| @@ -163,8 +163,6 @@ class runtime { | |||
| std::string const& url, | |||
| std::string const& request_id, | |||
| invocation_response const& handler_response); | |||
|
|
|||
| private: | |||
There was a problem hiding this comment.
What's the reason for making this public?
There was a problem hiding this comment.
clang-tidy pointed out that these were already made private a few lines up
ref: https://github.com/bmoffatt/aws-lambda-cpp/runs/4305830378?check_suite_focus=true
/home/runner/work/aws-lambda-cpp/aws-lambda-cpp/include/aws/lambda-runtime/runtime.h:167:1: error: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers,-warnings-as-errors]
private:
^~~~~~~~
/home/runner/work/aws-lambda-cpp/aws-lambda-cpp/include/aws/lambda-runtime/runtime.h:159:1: note: previously declared here
private:
^
There was a problem hiding this comment.
Ah! That's what I get for looking at this on a 5" phone screen.
marcomagdy
approved these changes
Nov 24, 2021
|
Please squash before merging. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.