Add clang-tidy identifier naming rules #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcomagdy
force-pushed
the
clang-tidy-naming-style
branch
from
e015804
to
78aa824
Compare
bmoffatt
requested changes
Mar 24, 2020
src/runtime.cpp
Outdated
| @@ -72,7 +72,7 @@ static size_t write_data(char* ptr, size_t size, size_t nmemb, void* userdata) | |||
| // std::isspace has a few edge cases that would trigger UB. In particular, the documentation says: | |||
| // "The behavior is undefined if the value of the input is not representable as unsigned char and is not equal to EOF." | |||
| // So, this function does the simple obvious thing instead. | |||
| static inline bool IsSpace(int ch) | |||
| static inline bool is_whiltespace(int ch) | |||
bmoffatt
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add clang-tidy rules to enforce naming style/conventions
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.