Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebAppFixture #153

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Add WebAppFixture #153

merged 1 commit into from
Oct 24, 2023

Conversation

ivy-lli
Copy link
Member

@ivy-lli ivy-lli commented Oct 20, 2023

No description provided.

@ivy-lli ivy-lli marked this pull request as ready for review October 23, 2023 12:47
@ivy-lli ivy-lli requested a review from ivy-rew October 23, 2023 13:24
@ivy-lli ivy-lli merged commit 110573b into master Oct 24, 2023
6 checks passed
@ivy-lli ivy-lli deleted the coolstuff/app-fixture branch October 24, 2023 05:42
*/
public void var(String name, String value) {
try {
var url = configRestUrl(VAR_PATH + "/" + name) + "?value=" + value;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hiho guys @ivy-lli and @ivy-rew

Had a quick look into this implementation, because I needed to fix something in another repo.
I can imagine that name and value are not properly encoded - only a URIBuilder can do this properly (imo).

But maybe I don't see the full picture here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes this was still "open", forgot about this yesterday...
I will have a look at it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants