Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change minimum versions of Node and eslint in integration tests #83

Merged
merged 2 commits into from
Dec 30, 2023

Conversation

azeemba
Copy link
Owner

@azeemba azeemba commented Dec 30, 2023

Node v16 is out of support. So we test against Node v18 and v20.

eslint 7 was released 4 years ago so its fair to not actively test again eslint 6. Speculativiely adding eslint 9 tests but not sure if that will work

Node v16 is out of support. So we test against Node v18 and v20.

eslint 7 was released 4 years ago so its fair to not actively test again
eslint 6. Speculativiely adding eslint 9 tests but not sure if that will
work
We weren't doing custom installations of different eslint versions
so we were always only testing one eslint version!

Added eslint-v9 test directory but it fails right now so not adding it
to CI.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e4a5603) 82.35% compared to head (82282d2) 82.35%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   82.35%   82.35%           
=======================================
  Files           1        1           
  Lines          51       51           
=======================================
  Hits           42       42           
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azeemba azeemba merged commit 893c508 into master Dec 30, 2023
2 checks passed
@azeemba azeemba deleted the minVersions branch December 30, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants