[TASK] Avoid usage of deprecated QueryBuilder::execute() in TYPO3 v12 #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do you forget some use statements? |
|
@achimfritz Should be fixed and rebased with current master now. |
|
we need also adapt phpstan rules (s. Build/phpstan.neon) s. https://github.com/b13/container/actions/runs/4828271563/jobs/8609709099 s. https://github.com/b13/container/blob/master/.github/workflows/ci.yml for usage of the runTest.sh Script, so you can test your changes |
kevin-appelt
force-pushed
the
patch-2
branch
2 times, most recently
from
e4b6c6f
to
1aecde1
Compare
|
@achimfritz Would be great to receive some feedback. Running the tests gave me a hard time and couldn't be executed entirely, but I guess it should be fine now. |
kevin-appelt
force-pushed
the
patch-2
branch
from
1aecde1
to
868756d
Compare
|
Rebased my patch to get the ci fix adjustments. Hope that helps to get the tests green :) |
kevin-appelt
force-pushed
the
patch-2
branch
from
868756d
to
d0d6774
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.