Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] PHP 8.2 CI and update cgl #411

Merged
merged 1 commit into from
May 25, 2023
Merged

[TASK] PHP 8.2 CI and update cgl #411

merged 1 commit into from
May 25, 2023

Conversation

achimfritz
Copy link
Contributor

No description provided.

@achimfritz achimfritz requested a review from bmack May 24, 2023 05:26
@S3b0
Copy link

S3b0 commented May 24, 2023

This will drop support of TYPO3 CMS 10.4, since it's not compatible with PHP8 caused by Classes/Tca/Registry.php:51 str_contains function. Just wanted to mention.

@achimfritz
Copy link
Contributor Author

@S3b0 are you sure? we have symfony/pollyfill-php80 which provides this function (https://github.com/symfony/polyfill-php80) (i would also assume that tests would fail if str_contains is not supported?)

@achimfritz achimfritz merged commit 0e84d13 into master May 25, 2023
@achimfritz achimfritz deleted the task/php8.2 branch May 25, 2023 05:07
@S3b0
Copy link

S3b0 commented May 25, 2023

@S3b0 are you sure? we have symfony/pollyfill-php80 which provides this function (https://github.com/symfony/polyfill-php80) (i would also assume that tests would fail if str_contains is not supported?)

Missed the polyfill. My bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants