[BUGFIX] normalizedParams for upgrade wizards #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmack
approved these changes
Nov 17, 2023
bnf
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Ack, should be fixed both in EXT:container and upstream.
Upstream fix is here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81969
reviewtypo3org
pushed a commit
to TYPO3/typo3
that referenced
this pull request
Nov 27, 2023
With #100885 the availability of the normalizedParams request attribute became a requirement for user sessions initialized with a custom PSR-7 request. Extensions like EXT:container relied on the fact that a plain request object could be passed to `Bootstrap::initializeBackendUser()`. This will be fixed in EXT:container[1] but in case other extensions relied on this as well, a fallback is now provided. [1] b13/container#461 Resolves: #102520 Related: #100885 Releases: main, 12.4 Change-Id: Idbf5a6b3d72ecab4a9943d7bb2febf41fa4b6635 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81969 Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by: Oliver Bartsch <bo@cedev.de> Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Oliver Bartsch <bo@cedev.de> Tested-by: Benjamin Franzke <ben@bnf.dev> Tested-by: core-ci <typo3@b13.com> Reviewed-by: Benjamin Franzke <ben@bnf.dev>
reviewtypo3org
pushed a commit
to TYPO3/typo3
that referenced
this pull request
Nov 27, 2023
With #100885 the availability of the normalizedParams request attribute became a requirement for user sessions initialized with a custom PSR-7 request. Extensions like EXT:container relied on the fact that a plain request object could be passed to `Bootstrap::initializeBackendUser()`. This will be fixed in EXT:container[1] but in case other extensions relied on this as well, a fallback is now provided. [1] b13/container#461 Resolves: #102520 Related: #100885 Releases: main, 12.4 Change-Id: Idbf5a6b3d72ecab4a9943d7bb2febf41fa4b6635 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81908 Reviewed-by: Benjamin Franzke <ben@bnf.dev> Tested-by: core-ci <typo3@b13.com> Tested-by: Benjamin Franzke <ben@bnf.dev>
TYPO3IncTeam
pushed a commit
to TYPO3-CMS/core
that referenced
this pull request
Nov 27, 2023
With #100885 the availability of the normalizedParams request attribute became a requirement for user sessions initialized with a custom PSR-7 request. Extensions like EXT:container relied on the fact that a plain request object could be passed to `Bootstrap::initializeBackendUser()`. This will be fixed in EXT:container[1] but in case other extensions relied on this as well, a fallback is now provided. [1] b13/container#461 Resolves: #102520 Related: #100885 Releases: main, 12.4 Change-Id: Idbf5a6b3d72ecab4a9943d7bb2febf41fa4b6635 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81969 Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by: Oliver Bartsch <bo@cedev.de> Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Oliver Bartsch <bo@cedev.de> Tested-by: Benjamin Franzke <ben@bnf.dev> Tested-by: core-ci <typo3@b13.com> Reviewed-by: Benjamin Franzke <ben@bnf.dev>
TYPO3IncTeam
pushed a commit
to TYPO3-CMS/core
that referenced
this pull request
Nov 27, 2023
With #100885 the availability of the normalizedParams request attribute became a requirement for user sessions initialized with a custom PSR-7 request. Extensions like EXT:container relied on the fact that a plain request object could be passed to `Bootstrap::initializeBackendUser()`. This will be fixed in EXT:container[1] but in case other extensions relied on this as well, a fallback is now provided. [1] b13/container#461 Resolves: #102520 Related: #100885 Releases: main, 12.4 Change-Id: Idbf5a6b3d72ecab4a9943d7bb2febf41fa4b6635 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81908 Reviewed-by: Benjamin Franzke <ben@bnf.dev> Tested-by: core-ci <typo3@b13.com> Tested-by: Benjamin Franzke <ben@bnf.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #460