[Endpoint] TypeError [ERR_INVALID_URL]: Invalid URL: http:/

[sentry-io]

Sentry Issue: SHIELDS-2Z

TypeError [ERR_INVALID_URL]: Invalid URL: http:/
  File "/home/m/shields/services/endpoint/endpoint.service.js", line 70, in Endpoint.handle
    const { protocol, hostname } = new URL(url)
  File "/home/m/shields/core/base-service/base.js", line 375, in Function.invoke
    serviceData = await serviceInstance.handle(
  File "/home/m/shields/core/base-service/base.js", line 423, in Object.handler
    const serviceData = await this.invoke(
  File "/home/m/shields/core/base-service/legacy-request-handler.js", line 243, in null.<anonymous>
    const result = handlerOptions.handler(
...
(5 additional frame(s) were not displayed)

[paulmelnikow]

This is either a bug or unexpected behavior in Joi. I opened hapijs/joi#1994.

[paulmelnikow]

Failing test:

t.create('Invalid URL')
  .get('.json?url=https:/')
  .expectBadge({ label: 'custom badge', message: 'invalid query parameter: url' })

[calebcartwright]

It's a bummer that we'll have to finish the v16 upgrade since the fix in joi wasn't ported into v15.x

[calebcartwright]

This should be resolved now that #4031 is complete, right?

[paulmelnikow]

Yep!

http://shields-staging.herokuapp.com/badge/dynamic/json?url=https:/&query=.

Want to add the test?

[calebcartwright]

Want to add the test?

sure, what did you have in mind? a service test with an invalid query param?

[paulmelnikow]

Yea, I meant like the one I pasted in above, which seems to be the same direction you went 😁