You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Somewhere along the line I updated to npm 9. In the process of resolving the merge conflict merging master into #9014 I reg-generated the lockfile with npm 9. This upgraded the lockfile format to version 3, which in turn broke the node 14 package build.
I think we need to either:
Set engines.npm to ^8.0.0 instead of >=8.0.0 in package.json if we want to keep testing badge-maker on node 14
Upgrade the lockfile format to v3 and drop node 14 compatibility for badge-maker (which we need to do anyway. I feel like there was a issue/PR where this came up recently, but I can't find it)
I'll probably do the second one, but I don't want to get completely bogged down in it right now.
The text was updated successfully, but these errors were encountered:
I think the other PR I was thinking about was #8959 - that one was about migrating badge-maker to ESM and dropping CJS, which is a slightly different issue than dropping node 14
📋 Description
Hit this while working on #9014
Somewhere along the line I updated to npm 9. In the process of resolving the merge conflict merging master into #9014 I reg-generated the lockfile with npm 9. This upgraded the lockfile format to version 3, which in turn broke the node 14 package build.
I think we need to either:
engines.npm
to^8.0.0
instead of>=8.0.0
inpackage.json
if we want to keep testing badge-maker on node 14I'll probably do the second one, but I don't want to get completely bogged down in it right now.
The text was updated successfully, but these errors were encountered: