Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generating lockfile with npm 9 breaks node 14 package build #9075

Closed
chris48s opened this issue Apr 11, 2023 · 2 comments · Fixed by #9323
Closed

generating lockfile with npm 9 breaks node 14 package build #9075

chris48s opened this issue Apr 11, 2023 · 2 comments · Fixed by #9323
Labels
npm-package Badge generation and badge templates

Comments

@chris48s
Copy link
Member

📋 Description

Hit this while working on #9014

Somewhere along the line I updated to npm 9. In the process of resolving the merge conflict merging master into #9014 I reg-generated the lockfile with npm 9. This upgraded the lockfile format to version 3, which in turn broke the node 14 package build.

I think we need to either:

  • Set engines.npm to ^8.0.0 instead of >=8.0.0 in package.json if we want to keep testing badge-maker on node 14
  • Upgrade the lockfile format to v3 and drop node 14 compatibility for badge-maker (which we need to do anyway. I feel like there was a issue/PR where this came up recently, but I can't find it)

I'll probably do the second one, but I don't want to get completely bogged down in it right now.

@chris48s chris48s added the npm-package Badge generation and badge templates label Apr 11, 2023
@chris48s
Copy link
Member Author

I think the other PR I was thinking about was #8959 - that one was about migrating badge-maker to ESM and dropping CJS, which is a slightly different issue than dropping node 14

@chris48s
Copy link
Member Author

Try to come back to this one once #9290 and #9289 are merged but before we get to next week's dependabot PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm-package Badge generation and badge templates
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant