upgrade to npm 9 #9323
Merged
upgrade to npm 9 #9323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris48s
added
developer-experience
|
chris48s
commented
Jun 26, 2023
| "node": ">= 14", | ||
| "npm": ">= 6" | ||
| "node": ">=16" |
There was a problem hiding this comment.
I've dropped the npm engine declaration completely from the badge-maker/package.json here. It is bad practice to include one because we're not distributing any lockfile, people might be installing it with yarn, etc
| @@ -212,7 +212,7 @@ | |||
| }, | |||
| "engines": { | |||
| "node": "^16.13.0", | |||
| "npm": ">=8.0.0" | |||
| "npm": "^9.0.0" | |||
There was a problem hiding this comment.
I've switched this to a caret. As we can see from this Pr, jumping a major NPM version tends to require some intervention/review from us
Merged
calebcartwright
previously approved these changes
Jul 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9075
🗒️ Notes:
npm i --lockfile-version 3 --package-lock-onlyis the command to force alockfileVersion2 --> 3 migration without actually installing/removing anything.